Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WebTransport protocol #4874

Closed
wants to merge 27 commits into from
Closed

feat: add WebTransport protocol #4874

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1c2c377
attempt to extend QUIC transport impl
dgarus Nov 16, 2023
8bf8d0c
example
dgarus Nov 16, 2023
cabc7de
example
dgarus Nov 16, 2023
83058d5
Merge branch 'master' into web-transport-quic
dgarus Nov 17, 2023
fdcd176
Merge branch 'master' into web-transport-quic
dgarus Nov 21, 2023
8325840
Merge branch 'master' into web-transport-quic
dgarus Nov 22, 2023
7a54fd3
Merge branch 'master' into web-transport-quic
dgarus Nov 23, 2023
dc80864
Merge branch 'master' into web-transport-quic
dgarus Dec 12, 2023
13cc3df
added CertManager
dgarus Dec 22, 2023
5ceccfd
Merge branch 'master' into web-transport-quic
dgarus Dec 22, 2023
cd9d646
Merge branch 'master' into web-transport-quic
dgarus Dec 25, 2023
10d97fe
noise
dgarus Dec 25, 2023
d418dc1
single endpoint for quic and wt
dgarus Dec 25, 2023
cefaebe
Merge remote-tracking branch 'origin/web-transport-quic' into web-tra…
dgarus Dec 25, 2023
94fd970
Merge branch 'master' into web-transport-quic
dgarus Dec 25, 2023
c1dca8c
Merge branch 'master' into web-transport-quic
dgarus Dec 29, 2023
d01f149
Merge branch 'master' into web-transport-quic
dgarus Jan 9, 2024
1f2297c
Merge branch 'master' into web-transport-quic
dgarus Jan 18, 2024
dc08909
msg
dgarus Jan 25, 2024
a3e3a5e
Merge remote-tracking branch 'origin/web-transport-quic' into web-tra…
dgarus Jan 25, 2024
2b06072
Merge branch 'master' into web-transport-quic
dgarus Jan 25, 2024
c3a8e7d
Merge branch 'master' into web-transport-quic
dgarus Feb 12, 2024
f024ded
Merge branch 'master' into web-transport-quic
dgarus Apr 16, 2024
1cdecf1
Merge branch 'master' into web-transport-quic
dgarus May 2, 2024
9b8b27e
Merge branch 'master' into web-transport-quic
dgarus May 7, 2024
c5ff302
Merge branch 'refs/heads/master' into web-transport-quic
dgarus Jul 9, 2024
098b58b
Merge branch 'master' into web-transport-quic
dgarus Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 71 additions & 19 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion transports/quic/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,17 @@ tokio = { version = "1.35.1", default-features = false, features = ["net", "rt",
tracing = "0.1.37"
socket2 = "0.5.5"
ring = "0.16.20"
sha2 = "0.10.7"
hex = "0.4"

# WebTransport
http = "1.0.0"
h3 = { git = "https://github.com/hyperium/h3" }
h3-quinn = { git = "https://github.com/hyperium/h3" }
h3-webtransport = { git = "https://github.com/hyperium/h3" }
Comment on lines +36 to +38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no released versions of these libraries yet? We won't be able to merge this without released versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With git versions, everything is ok:

image

But when I define h3 = "0.0.4" I got two versions 0.0.3 and 0.0.4:

image

And, accordingly, I got a lot of errors.
I stuck with this problem for the first time, do you know how to fix it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because there hasn't yet been a release of h3-webtransport with h3 0.0.4. See https://crates.io/crates/h3-webtransport/0.1.0/dependencies. I'd suggest nudging the maintainers for a new release!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG
Thanks, I'll do it a bit later

libp2p-noise = { workspace = true }
rcgen = "0.11.3"
time = "0.3"

[features]
tokio = ["dep:tokio", "if-watch/tokio", "quinn/runtime-tokio"]
Expand All @@ -42,12 +53,12 @@ rustc-args = ["--cfg", "docsrs"]
async-std = { version = "1.12.0", features = ["attributes"] }
libp2p-identity = { workspace = true, features = ["rand"] }
libp2p-muxer-test-harness = { path = "../../muxers/test-harness" }
libp2p-noise = { workspace = true }
libp2p-tcp = { workspace = true, features = ["async-io"] }
libp2p-yamux = { workspace = true }
quickcheck = "1"
tokio = { version = "1.35.1", features = ["macros", "rt-multi-thread", "time"] }
tracing-subscriber = { version = "0.3", features = ["env-filter"] }
hex-literal = "0.4"

[[test]]
name = "stream_compliance"
Expand Down
Loading
Loading