Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node-datachannel WebRTC polyfill #2306

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

achingbrain
Copy link
Member

node-datachannel has shipped a WebRTC polyfill for the last few versions so use that instead of our own version.

Refs: murat-dogan/node-datachannel#185

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

node-datachannel has shipped a WebRTC polyfill for the last few versions
so use that instead of our own version.

Refs: murat-dogan/node-datachannel#185
@achingbrain achingbrain requested a review from a team as a code owner December 7, 2023 15:28
@achingbrain
Copy link
Member Author

Just waiting on a node-datachannel release for this.

@achingbrain achingbrain merged commit ad6f70b into main Dec 18, 2023
22 checks passed
@achingbrain achingbrain deleted the fix/use-node-datachannel-webrtc-polyfill branch December 18, 2023 07:50
@achingbrain achingbrain mentioned this pull request Dec 18, 2023
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant