Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

feat: create dockerfile for docker hub integration #209

Merged
merged 4 commits into from
Mar 16, 2020
Merged

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Mar 6, 2020

  • Adds a Dockerfile to the repo so that we can integrate image builds in libp2p Docker Hub
  • Removes Procfile associated with old deployment setup

Additional Fixes

  • Use pkg.files instead of .npmignore
  • Fix dependency usage of prom-client

Building and running the container

You can build and run the container locally via:

Build: docker build -t libp2p/webrtc-star .
Run: docker run -it -p 9090:9090 --env DEBUG=signalling-server,signalling-server:error libp2p/webrtc-star

TODO:

unblocks libp2p infra team deployment of #180

Dockerfile Outdated Show resolved Hide resolved
chore: fix spelling in docker file

Co-Authored-By: Vasco Santos <[email protected]>
@jacobheun jacobheun force-pushed the feat/docker branch 3 times, most recently from d8260eb to f4f19fc Compare March 12, 2020 14:29
@jacobheun jacobheun marked this pull request as ready for review March 12, 2020 14:39
@jacobheun
Copy link
Contributor Author

@vasco-santos CI is failing due to an unrelated issue with Firefox. I did some local testing and it looks like the recent version of Firefox (74), which came out on March 10 is causing some issues. I verified test failures locally on Firefox 74 and passing test on Firefox 72 (the previous version). I'll create an issue to track fixing this, currently not sure what's causing the issues.

@jacobheun jacobheun changed the title feat: create dockerfile for docker hub intergration feat: create dockerfile for docker hub integration Mar 12, 2020
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vasco-santos vasco-santos merged commit ac1eb8a into master Mar 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants