feat: remove dht.getPublicKey

[achingbrain]

The dht.getPublicKey method is a specialised dht.get so you should just call that with the right key value.

This lets us remove the libp2p-crypto dependency as we were using it to unmarshal the returned key - if you are interested in a node's public key you're probably about to do something with it in which case you probably have a dep on libp2p-crypto so no need for this module to have one.

BREAKING CHANGE: dht.getPublicKey has been removed

[hugomrdias]

Im being picky here but that stablelib doesnt do the node/browser swap includes both and if the bundler doesnt do treeshaking it includes even more stuff.

Perfect scenario would be libp2p-crypto/random or a new package with the https://github.com/hugomrdias/iso-random-stream/blob/master/src/random.browser.js (could be improved with the clever for from the stablelib impl) , https://github.com/hugomrdias/iso-random-stream/blob/master/src/random.js and the browser swap in package.json.

the rest LGTM

[achingbrain]

Im being picky here

That's fine, I've not got a strong opinion about which randomBytes implementation to use.

Perfect scenario would be libp2p-crypto/random

I disagree because this module only needs a random number generator, not a full crypto suite.

Yes, a clever bundler would make sure only what's used is bundled, but for example if we wanted to make a breaking change in libp2p-crypto/foo-bar, this module would be involved in the roll-out of that breaking change even though it doesn't use that code at all.

or a new package with the hugomrdias/iso-random-stream@master/src/random.browser.js (could be improved with the clever for from the stablelib impl) , hugomrdias/iso-random-stream@master/src/random.js and the browser swap in package.json.

Sounds preferable - would merge!

[achingbrain]

@hugomrdias I've reverted to iso-random-stream but it needs hugomrdias/iso-random-stream#87 before the build will pass here.

[achingbrain]

Superseded by #300