Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics via Prometheus #313

Closed
wants to merge 10 commits into from
Closed

Add metrics via Prometheus #313

wants to merge 10 commits into from

Conversation

anacrolix
Copy link
Contributor

This is #297 but using Prometheus. I already have this locally, and figure it might aid discussion in libp2p/go-libp2p#522.

@ghost ghost assigned anacrolix Mar 27, 2019
@ghost ghost added the status/in-progress In progress label Mar 27, 2019
@ghost
Copy link

ghost commented Mar 27, 2019 •
edited by ghost
Loading

@Kubuxu probably has useful feedback since he did the metrics system in go-ipfs -- edit: oh, I see, libp2p/go-libp2p#522 is where to discuss

@anacrolix
Copy link
Contributor Author

anacrolix commented Mar 27, 2019 •
edited
Loading

Thanks @lgierth, I look forward to your feedback too.

@anacrolix anacrolix requested a review from Kubuxu March 27, 2019 23:29
@anacrolix
Copy link
Contributor Author

Closing this in favour of #297.

@anacrolix anacrolix closed this Apr 15, 2019
@ghost ghost removed the status/in-progress In progress label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@guillaumemichel guillaumemichel Awaiting requested review from guillaumemichel guillaumemichel will be requested when the pull request is marked ready for review guillaumemichel is a code owner

Assignees

@anacrolix anacrolix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anacrolix @lanzafame