PWX-38372 Cherry-picking diags code from master #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachaudhary-px
requested review from
nikita-bhatia,
dtalreja-px and
arokade-px
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hk-feature-clusterDiags #1638 +/- ##
===========================================================
- Coverage 79.82% 79.53% -0.30%
===========================================================
Files 61 63 +2
Lines 18499 19072 +573
===========================================================
+ Hits 14767 15168 +401
- Misses 2669 2803 +134
- Partials 1063 1101 +38 ☔ View full report in Codecov by Sentry. |
pnookala-px
reviewed
Aug 13, 2024
| cli.BoolFlag{ | ||
| Name: flagEnableDiagController, | ||
| Usage: "Enable Portworx Diag Controller (default: false)", | ||
| }, |
There was a problem hiding this comment.
Can default be true in your branch?
There was a problem hiding this comment.
Yes, we can do that
kachaudhary-px
added a commit
that referenced
this pull request
Sep 9, 2024
* cherry-picking diags code from master * fixed gofmt * fixup for test cases * fixup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PWX-38372 (Cherry-pick)
This PR has cluster diags code checked out from master.