Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of storageops for Azure Disks #944

Merged
merged 5 commits into from
Mar 21, 2019
Merged

Implementation of storageops for Azure Disks #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de04ef3
Vendor azure sdk v14.0.0 and go-autorest v10.1.0
Mar 15, 2019
99607ef
Implementation of storage ops for Azure
Mar 15, 2019
8f17515
Adding readme to run azure tests
Mar 15, 2019
717eea3
Skip Azure tests if env variables are not set
Mar 18, 2019
a181e13
Azure disk create should fail if disk already exists
Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,13 @@ docker-test: docker-build-osd-dev
-e GCE_INSTANCE_NAME \
-e GCE_INSTANCE_ZONE \
-e GCE_INSTANCE_PROJECT \
-e AZURE_INSTANCE_NAME \
-e AZURE_SUBSCRIPTION_ID \
-e AZURE_RESOURCE_GROUP_NAME \
-e AZURE_ENVIRONMENT \
-e AZURE_TENANT_ID \
-e AZURE_CLIENT_ID \
-e AZURE_CLIENT_SECRET \
-e "TAGS=$(TAGS)" \
-e "PKGS=$(PKGS)" \
-e "BUILDFLAGS=$(BUILDFLAGS)" \
Expand Down Expand Up @@ -398,4 +405,3 @@ push-docker-images: docker-images
# For release branches, major and minor should be frozen.
sdk-check-version:
go run tools/sdkver/sdkver.go --check-major=0 --check-patch=0

14 changes: 14 additions & 0 deletions pkg/storageops/azure/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
### To test Azure

You will first need to create a Azure instance and then provide details of this instance as below.

```bash
export AZURE_INSTANCE_NAME=<instance-name>
export AZURE_SUBSCRIPTION_ID=<subscription-id>
export AZURE_RESOURCE_GROUP_NAME=<resource-group-name-of-instance>
export AZURE_ENVIRONMENT=<azure-cloud-environment>
export AZURE_TENANT_ID=<tenant-id>
export AZURE_CLIENT_ID=<client-id>
export AZURE_CLIENT_SECRET=<client-secret>
go test
```
Loading