PWX-36522: In case of devices use Exact match with mount and not a pr… #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efix match Signed-off-by: pnookala-px <[email protected]>
Pure-AdamuKaapan
approved these changes
Mar 21, 2024
pnookala-px
added a commit
that referenced
this pull request
Mar 21, 2024
…efix match (#2431) Signed-off-by: pnookala-px <[email protected]>
pnookala-px
added a commit
that referenced
this pull request
Mar 21, 2024
…efix match (#2431) (#2432) Signed-off-by: pnookala-px <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…efix match
PWX-36522: When the devices are of the format /dev/dm- and we do a prefix search, the search will lead incorrect match for ./dev/dm-. Instead when searching for Target Devices, check for exact match.
Testing:
On the system that had devices in the specified format installed binary and verified that filesystems/devices are rightly identified and pods come up properly.
Tested on a Aetos setup with a mix of RWO/RWX/FADA pods and kept restarting px randomly on all nodes. Pods came up cleanly.