Add generic schedule structure; add fields for defrag schedule #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adikulkarni0
reviewed
Feb 2, 2024
| // MaxDurationHours defines the time limit of one run in hours | ||
| double max_duration_hours = 3; | ||
| // Type is the type of job to run | ||
| Job.Type type = 4; |
There was a problem hiding this comment.
Is Job.Type not part of Job that is repeated below?
There was a problem hiding this comment.
If it is intended to be a Schedule Type lets use that
There was a problem hiding this comment.
Yes it's intended to denote the schedule type. And it should be one of the Job.Type.
adikulkarni0
approved these changes
Feb 2, 2024
|
This PR is stale because it has been in review for 3 days with no activity. |
Signed-off-by: Tengxiao Wang <[email protected]>
Signed-off-by: Tengxiao Wang <[email protected]>
Signed-off-by: Tengxiao Wang <[email protected]>
Signed-off-by: Tengxiao Wang <[email protected]>
Signed-off-by: Tengxiao Wang <[email protected]>
twang-ps
force-pushed
the
defrag_schedule
branch
from
0f83f33
to
acd5a69
Compare
Signed-off-by: Tengxiao Wang <[email protected]>
Signed-off-by: Tengxiao Wang <[email protected]>
twang-ps
added a commit
to twang-ps/openstorage
that referenced
this pull request
Jul 9, 2024
…enstorage#2408) * Add generic Schedule data structure * Add last_update_time to DefragNodeStatus * Add schedule_one_iteration_only to DefragJob (cherry picked from commit 5aaf214) Signed-off-by: Tengxiao Wang <[email protected]>
twang-ps
added a commit
that referenced
this pull request
Jul 10, 2024
* Add a new type of Job: DefragJob (#2375) (cherry picked from commit 759bca7) * Add defrag status data structures (#2385) (cherry picked from commit def904a) * Add generic schedule structure; add fields for defrag schedule (#2408) (cherry picked from commit 5aaf214) * Add server and APIs for defrag and schedule services (#2426) (cherry picked from commit e80fd7f) * Change OpenStorageSchedule API parameter type to string (#2454) (cherry picked from commit e4b050e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR added a generic
Scheduleproto message. It defines a schedule with start time, max duration, and the tasks to run.Also added
schedule_one_iteration_onlyfield toDefragJobfor one-iteration-only defrag schedule.Added
last_update_timetoDefragNodeStatusWhich issue(s) this PR fixes (optional)
Closes #
or
PWX-
Testing Notes
Add testing output or passing unit test output here.
Special notes for your reviewer:
Add any notes for the reviewer here.