PWX-33580 Run stat command with timeout during NFS Unmount #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vignesh Laxman <[email protected]>
Signed-off-by: Vignesh Laxman <[email protected]>
|
This PR is stale because it has been in review for 3 days with no activity. |
pnookala-px
approved these changes
Jan 30, 2024
vlaxman-px
changed the title
vlaxman-px
added a commit
that referenced
this pull request
Jul 11, 2024
* Made changes to run stat command with a timeout of 60 secondss Signed-off-by: Vignesh Laxman <[email protected]> * Change implementation using context as pexec is part of porx Signed-off-by: Vignesh Laxman <[email protected]> --------- Signed-off-by: Vignesh Laxman <[email protected]>
vlaxman-px
added a commit
that referenced
this pull request
Jul 11, 2024
…2457) * Made changes to run stat command with a timeout of 60 secondss * Change implementation using context as pexec is part of porx --------- Signed-off-by: Vignesh Laxman <[email protected]>
vlaxman-px
added a commit
that referenced
this pull request
Jul 12, 2024
vlaxman-px
added a commit
that referenced
this pull request
Jul 12, 2024
* Made changes to run stat command with a timeout of 60 secondss Signed-off-by: Vignesh Laxman <[email protected]> * Change implementation using context as pexec is part of porx Signed-off-by: Vignesh Laxman <[email protected]> --------- Signed-off-by: Vignesh Laxman <[email protected]>
vlaxman-px
added a commit
that referenced
this pull request
Jul 12, 2024
…2403) (#2457)" This reverts commit 0ba1aa1. Signed-off-by: Vignesh Laxman <[email protected]>
vlaxman-px
added a commit
that referenced
this pull request
Jul 12, 2024
…2403) (#2457)" (#2458) This reverts commit 0ba1aa1. Signed-off-by: Vignesh Laxman <[email protected]>
vlaxman-px
added a commit
that referenced
this pull request
Jul 12, 2024
…2459) * Made changes to run stat command with a timeout of 60 secondss * Change implementation using context as pexec is part of porx --------- Signed-off-by: Vignesh Laxman <[email protected]>
sulakshm
pushed a commit
that referenced
this pull request
Jul 13, 2024
…2403) (#2457)" (#2458) This reverts commit 0ba1aa1. Signed-off-by: Vignesh Laxman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
NFS Unmount call gets routed to RemoveMountPath, which can get stuck in “stats“ system call in case of an offline NFS server. To rectify this, changes has been made where stat command is run remotely along with a timeout of 60 seconds. This helps the system not to hang and retry the command every one minute.
Which issue(s) this PR fixes (optional)
PWX-33580
Testing Notes
I tested the change with an Infof with my name to check if the code is running as expected. The change is working and the retry happens after the specified timeout.