Skip to content

Commit

Permalink
Expose some types that are used in exposed APIs
Browse files Browse the repository at this point in the history
`com.ibm.wala.cast.test.TestCAstTranslator.checkAssertions` is a
`public` method that takes an argument of type
`com.ibm.wala.cast.test.TestCAstTranslator.TranslatorAssertions`.  The
latter, therefore, needs to be `public` as well or else the
checkAssertions` method can never be called.

Similarly,
`com.ibm.wala.core.tests.shrike.DynamicCallGraphTestBase.check` is a
`protected` method that takes an argument of type
`com.ibm.wala.core.tests.shrike.DynamicCallGraphTestBase.EdgesTest`.
The latter must at least have `protected` visibility too, or else the
`check` method can never be called.
  • Loading branch information
liblit committed Oct 16, 2023
1 parent 28b06aa commit 6b4aff9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

public abstract class TestCAstTranslator {

protected static class TranslatorAssertions {
public static class TranslatorAssertions {
private final Set<String> classes = new HashSet<>();

private final Map<String, String> supers = new HashMap<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ protected void run(String mainClass, String exclusionsFile, String... args)
assertTrue(Files.exists(cgLocation), "expected to create call graph");
}

interface EdgesTest {
protected interface EdgesTest {
void edgesTest(CallGraph staticCG, CGNode caller, MethodReference callee);
}

Expand Down

0 comments on commit 6b4aff9

Please sign in to comment.