Merge branch 'master' into Gradle-8.11

core/src/main/java/com/ibm/wala/core/util/strings/StringStuff.java

@@ -72,9 +72,7 @@ public static String deployment2CanonicalTypeString(String dString) {
       String baseType = dString.substring(0, arrayIndex);
       int dim = (dString.length() - arrayIndex) / 2;
       baseType = deployment2CanonicalTypeString(baseType);
-      StringBuilder result = new StringBuilder("[".repeat(dim));
-      result.append(baseType);
-      return result.toString();
+      return "[".repeat(dim) + baseType;
     } else {
       if (primitiveClassNames.get(dString) != null) {
         return primitiveClassNames.get(dString);
@@ -102,9 +100,7 @@ public static String deployment2CanonicalDescriptorTypeString(String dString) {
       String baseType = dString.substring(0, arrayIndex);
       int dim = (dString.length() - arrayIndex) / 2;
       baseType = deployment2CanonicalDescriptorTypeString(baseType);
-      StringBuilder result = new StringBuilder("[".repeat(dim));
-      result.append(baseType);
-      return result.toString();
+      return "[".repeat(dim) + baseType;
     } else {
       if (primitiveClassNames.get(dString) != null) {
         return primitiveClassNames.get(dString);

core/src/main/java/com/ibm/wala/ipa/callgraph/propagation/ConcreteTypeKey.java

@@ -71,7 +71,7 @@ public IClass getConcreteType() {
   /**
    * @param pei a PEI instruction
    * @param cha governing class hierarchy
-   * @return a set of ConcreteTypeKeys that represent the exceptions the PEI may throw.
+   * @return an array of ConcreteTypeKeys that represent the exceptions the PEI may throw.
    * @throws IllegalArgumentException if pei is null
    */
   public static InstanceKey[] getInstanceKeysForPEI(SSAInstruction pei, IClassHierarchy cha) {

core/src/main/java/com/ibm/wala/ssa/SSABuilder.java

@@ -1085,9 +1085,7 @@ public String[] getLocalNames(int index, int vn) {
 
     public int[] allocateNewLocalsArray(int maxLocals) {
       int[] result = new int[maxLocals];
-      for (int i = 0; i < maxLocals; i++) {
-        result[i] = OPTIMISTIC ? TOP : BOTTOM;
-      }
+      Arrays.fill(result, OPTIMISTIC ? TOP : BOTTOM);
       return result;
     }
 

util/src/main/java/com/ibm/wala/fixedpoint/impl/GeneralStatement.java

@@ -12,6 +12,7 @@
 
 import com.ibm.wala.fixpoint.AbstractOperator;
 import com.ibm.wala.fixpoint.AbstractStatement;
+import com.ibm.wala.fixpoint.FixedPointConstants;
 import com.ibm.wala.fixpoint.IVariable;
 import org.jspecify.annotations.NullUnmarked;
 
@@ -30,7 +31,8 @@ public abstract class GeneralStatement<T extends IVariable<T>>
   /**
    * Evaluate this equation, setting a new value for the left-hand side.
    *
-   * @return true if the lhs value changed. false otherwise
+   * @return a constant defined by {@link FixedPointConstants} that reflects whether the lhs value
+   *     changed
    */
   @Override
   public byte evaluate() {

util/src/main/java/com/ibm/wala/fixedpoint/impl/NullaryOperator.java

@@ -12,6 +12,7 @@
 package com.ibm.wala.fixedpoint.impl;
 
 import com.ibm.wala.fixpoint.AbstractOperator;
+import com.ibm.wala.fixpoint.FixedPointConstants;
 import com.ibm.wala.fixpoint.IVariable;
 
 /** An operator of the form lhs = op */
@@ -25,7 +26,8 @@ public byte evaluate(T lhs, T[] rhs) throws UnsupportedOperationException {
   /**
    * Evaluate this equation, setting a new value for the left-hand side.
    *
-   * @return true if the lhs value changes. false otherwise.
+   * @return a constant defined by {@link FixedPointConstants} that reflects whether the lhs value
+   *     changed
    */
   public abstract byte evaluate(T lhs);
 }

util/src/main/java/com/ibm/wala/fixedpoint/impl/NullaryStatement.java

@@ -11,6 +11,7 @@
 package com.ibm.wala.fixedpoint.impl;
 
 import com.ibm.wala.fixpoint.AbstractStatement;
+import com.ibm.wala.fixpoint.FixedPointConstants;
 import com.ibm.wala.fixpoint.IVariable;
 
 /** Represents a single step, restricted to a nullary operator. */
@@ -23,7 +24,8 @@ public abstract class NullaryStatement<T extends IVariable<T>>
   /**
    * Evaluate this equation, setting a new value for the left-hand side.
    *
-   * @return true if the lhs value changed. false otherwise
+   * @return a constant defined by {@link FixedPointConstants} that reflects whether the lhs value
+   *     changed
    */
   @Override
   public byte evaluate() {

util/src/main/java/com/ibm/wala/fixpoint/UnaryOperator.java

@@ -20,7 +20,8 @@ public abstract class UnaryOperator<T extends IVariable<T>> extends AbstractOper
   /**
    * Evaluate this equation, setting a new value for the left-hand side.
    *
-   * @return true if the lhs value changes. false otherwise.
+   * @return a constant defined by {@link FixedPointConstants} that reflects whether the lhs value
+   *     changed
    */
   public abstract byte evaluate(@Nullable T lhs, T rhs);
 

util/src/main/java/com/ibm/wala/fixpoint/UnaryStatement.java

@@ -24,7 +24,8 @@ public abstract class UnaryStatement<T extends IVariable<T>>
   /**
    * Evaluate this equation, setting a new value for the left-hand side.
    *
-   * @return true if the lhs value changed. false otherwise
+   * @return a constant defined by {@link FixedPointConstants} that reflects whether the lhs value
+   *     changed
    */
   @Override
   public byte evaluate() {

util/src/main/java/com/ibm/wala/util/heapTrace/HeapTracer.java

@@ -150,7 +150,7 @@ private static Collection<String> findClassNames(String rootDir, File f) {
   }
 
   /**
-   * @return set of strings that are names of directories that contain "bin"
+   * @return duplicate-free array of strings that are names of directories that contain "bin"
    */
   private static Object[] extractBinDirectories(String classpath) {
     StringTokenizer t = new StringTokenizer(classpath, ";");