Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Display to set render stage names #32

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Use Display to set render stage names #32

merged 1 commit into from
Oct 5, 2024

Conversation

tirr-c
Copy link
Collaborator

@tirr-c tirr-c commented Oct 5, 2024

Use Display::fmt instead of separate name method, like std::error::Error does. (.to_string() can be used if String is needed.)

@tirr-c tirr-c requested a review from veluca93 October 5, 2024 07:46
veluca93
veluca93 approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@veluca93 veluca93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I wasn't sure about using display when I decided to add name() but it does look quite a bit nicer this way

jxl/src/render/simple_pipeline.rs Outdated Show resolved Hide resolved
@tirr-c tirr-c merged commit 7229eb7 into libjxl:main Oct 5, 2024
3 checks passed
@tirr-c tirr-c deleted the render-stage-name branch October 5, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veluca93 veluca93 veluca93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tirr-c @veluca93