Flag ELF32 as unsupported #912
Open
+53
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't currently support ELF32 symbol sources, but we don't detect them either and report a proper error. Rather, we just treat them as ELF64, which will turn bad sooner rather than later. With this change we make sure to detect ELF32 sources and report them as unsupported to make sure that there is no ambiguity what the problem is. Signed-off-by: Daniel Müller <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
- Coverage 94.54% 94.54% -0.01%
==========================================
Files 57 57
Lines 10218 10229 +11
==========================================
+ Hits 9661 9671 +10
- Misses 557 558 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently support ELF32 symbol sources, but we don't detect them either and report a proper error. Rather, we just treat them as ELF64, which will turn bad sooner rather than later. With this change we make sure to detect ELF32 sources and report them as unsupported to make sure that there is no ambiguity what the problem is.