Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Merged branches are ignored #208 #209

Closed
wants to merge 0 commits into from
Closed

fix: Merged branches are ignored #208 #209

wants to merge 0 commits into from

Conversation

LaurentMarchelli
Copy link
Contributor

fixes: #208

@LaurentMarchelli LaurentMarchelli requested a review from a team as a code owner November 17, 2023 18:44
@github-actions github-actions bot added the go label Nov 17, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (68bc840) 61.44% compared to head (bf9c6d8) 61.44%.

Files Patch % Lines
...r/internal/scraper/githubscraper/github_scraper.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   61.44%   61.44%           
=======================================
  Files           9        9           
  Lines         690      690           
=======================================
  Hits          424      424           
  Misses        242      242           
  Partials       24       24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adrielp
adrielp reviewed Nov 20, 2023
View reviewed changes
pkg/receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go Outdated
@@ -176,7 +176,7 @@ func (ghs *githubScraper) processBranches(
) {

for _, branch := range branches {
if branch.Name == branch.Repository.DefaultBranchRef.Name || branch.Compare.BehindBy == 0 {
if branch.Name == branch.Repository.DefaultBranchRef.Name {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having conversation on #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrielp adrielp adrielp left review comments

Assignees
No one assigned
Labels
go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merged branches are ignored
2 participants
@LaurentMarchelli @adrielp