fix: make general improvements #199
Open
+100
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vashian
reviewed
Dec 2, 2024
vashian
reviewed
Dec 2, 2024
src/base.ts
Outdated
Comment on lines
262
to
268
| const { api_token } = config.account | ||
| ? await this.getAccount(config.account) | ||
| : await this.getCurrentAccount(); | ||
|
|
||
| config['api-token'] = config['api-token'] || api_token; | ||
| config.region = config.region || region; | ||
| // config.region = config.region || region; | ||
| } |
There was a problem hiding this comment.
Don't forget that all accounts have a region field in the global configuration file liara-auth.json
I believe we shouldn't modify this global config file. To eliminate the prompt asking for the region, we can simply set a fallback region to "IRAN" and never prompt the user for a region.
Additionally, we should only remove the --region flag for simplicity.
For backward compatibility, in my opinion, we should automatically set the region to "IRAN". This ensures nothing unexpected happens in the CLI and keeps the region field hidden from the user.
This approach will streamline the process and improve the user experience.
PING @mhemrg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.