[#21] [#8] As a user, I can login with an email and password #35

liamstevens111 · 2023-02-16T06:49:12Z

What happened 👀

Setup Base Adapter and Auth Adapter (includes client_id, client_secret) for performing requests with RequestManager
Setup environment variables for base URL and client and secret
Perform login request and store access_token and refresh_token from response in LocalStorage
Perform validation and handle API error and success responses on UI
Tests / Mocks for Login page, API requests + Adapters etc

Protecting survey pages and redirecting to homepage has been separated to another issue here: #25

Maintaining a session by obtaining a new access token with refresh token been moved to separate ticket here: #36

Insight 📝

Used global localStorage mock due to being client wide library and unable to be mocked naturally by Jest
Used nock package for API request mocking for login page and AuthAdapter
Used setupTests to set the values for environment variables in tests
Real email/password used in cypress test, unsure on this one.

Proof Of Work 📹

Tests pass

netlify · 2023-02-16T06:49:16Z

✅ Deploy Preview for moonlit-buttercream-05cb2f ready!

Name	Link
🔨 Latest commit	`71150ac`
🔍 Latest deploy log	https://app.netlify.com/sites/moonlit-buttercream-05cb2f/deploys/64080d54c348a400072105a0
😎 Deploy Preview	https://deploy-preview-35--moonlit-buttercream-05cb2f.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2023-02-16T06:50:19Z

🚀 Deployed on https://64080d928f58c9556b86d570--moonlit-buttercream-05cb2f.netlify.app

…functionality wip

…for tokens

…de - will remove

…ntirely of application

…pe optional

…ubmit event instead button click

hanam1ni

I get not found page when trying to access login path on preview site. Not sure, if I am doing something wrong 🤔

hanam1ni · 2023-02-27T02:26:14Z

src/screens/Login/index.tsx

+
+      navigate('/');
+    } catch (error) {
+      let errorMessage = 'There was a problem receiving a response from the server';


Should we add this base error message to the translation file?

Yup, forgot that one :)

Added here 61d68f0

hanam1ni · 2023-02-27T02:38:49Z

src/adapters/baseAdapter..ts

+    return requestManager('GET', `${BaseAdapter.baseUrl}/${endpoint}`, params);
+  }
+
+  postRequest(endpoint: string, params: RequestParamsType) {


Should this be request option to be more accurate with the request manager?

Suggested change

postRequest(endpoint: string, params: RequestParamsType) {

postRequest(endpoint: string, requestOption: RequestParamsType) {

I used the naming conventions from Compass so I think should be default, but I can go with this as well

edit: changed here 9d0540f 👍

liamstevens111 · 2023-03-01T03:56:42Z

I get not found page when trying to access login path on preview site. Not sure, if I am doing something wrong 🤔

@hanam1ni Yes, I noticed this too so I waited until merged to main to see. I think this will resolve the issue:

https://stackoverflow.com/questions/50752350/page-not-found-when-trying-to-access-a-site-deployed-on-netlify

Works now, I made following changes: 9538bf5. It involved creating a _redirects file.

Login page: https://63fedb58e0e03327cdf00509--moonlit-buttercream-05cb2f.netlify.app/login

Edit: Woops, login page doesn't send request correctly as client id and secret not in environment, or the URL. I added to netlify but not sure I need in workflow too, dont think so.

… requestOption

src/screens/Login/index.tsx

rosle · 2023-03-07T07:13:44Z

src/screens/Login/index.tsx

+        <Input
+          name="email"
+          label={t('login.email')}
+          type="text"


why don't we use type="email" 🤔 or we want to use custom validation here?

yeah I didn't want the html5 default errors to appear on the page for the control (which I think is what would happen). What do you think? Is it not the preferred approach?

rosle · 2023-03-07T07:14:41Z

src/screens/Login/index.tsx

+          className="my-3 block h-14 w-80"
+          onInputChange={handleEmailChange}
+        />
+        <div className="relative w-80">


Maybe we don't need w-80 as we already set the width of the password input itself 💭

This comment and previous rectified here 👍

9929fd1

rosle · 2023-03-07T07:18:50Z

src/screens/Login/index.tsx

+    <>
+      <img className="inline-block" src={logo} alt="logo" />
+      <p data-test-id="login-header" className="my-8 text-white opacity-50">
+        {t('login.sign-in')} to Nimble


Should we extract the whole text for translation? 🤔 (including to Nimble)

I answered that in a previous PR - #33 (comment)

My thinking was that Nimble is the company name and I don't think we should "translate" the company name? I think it would be the same in all languages? Let me know if you think otherwise :)

… cypress tests have API data

liamstevens111 · 2023-03-08T04:25:56Z

I fixed cypress tests by adding environment variables to github workflow.

I added environment variables to Netlify but the preview is still showing "undefined" for URL during /login:

Unsure at the moment, maybe I can address this in my other open PR #34. Is that OK?

cc @hanam1ni

liamstevens111 changed the base branch from develop to feature/7-login-page February 16, 2023 06:49

github-actions bot temporarily deployed to pull request February 16, 2023 06:50 Inactive

liamstevens111 changed the title ~~Feature/21 backend login email password~~ [#21] [Backend] As a user, I can login with an email and password Feb 16, 2023

liamstevens111 self-assigned this Feb 16, 2023

liamstevens111 added the feature New feature or request label Feb 16, 2023

liamstevens111 added this to the 0.1.0 milestone Feb 16, 2023

github-actions bot temporarily deployed to pull request February 16, 2023 10:04 Inactive

github-actions bot temporarily deployed to pull request February 16, 2023 10:59 Inactive

liamstevens111 changed the title ~~[#21] [Backend] As a user, I can login with an email and password~~ [#21] [Backend] As a user, I can login with an email and password, [#8] [UI] As a user, I can login with an email and password Feb 17, 2023

github-actions bot temporarily deployed to pull request February 17, 2023 08:34 Inactive

liamstevens111 force-pushed the feature/21-backend-login-email-password branch from fe714c3 to 8b55683 Compare February 17, 2023 08:36

github-actions bot temporarily deployed to pull request February 17, 2023 08:37 Inactive

github-actions bot temporarily deployed to pull request February 17, 2023 11:32 Inactive

github-actions bot temporarily deployed to pull request February 18, 2023 19:51 Inactive

github-actions bot temporarily deployed to pull request February 20, 2023 03:43 Inactive

liamstevens111 force-pushed the feature/7-login-page branch from 694e8e8 to ceffe70 Compare February 21, 2023 08:19

liamstevens111 force-pushed the feature/21-backend-login-email-password branch from 8f0e4e8 to 102e630 Compare February 21, 2023 08:27

github-actions bot temporarily deployed to pull request February 21, 2023 08:33 Inactive

github-actions bot temporarily deployed to pull request February 22, 2023 05:06 Inactive

github-actions bot temporarily deployed to pull request February 22, 2023 08:25 Inactive

liamstevens111 added 8 commits February 22, 2023 16:04

[#25] Initial

13e34ac

[#21] Base and Auth adapter for sending request, only includes login …

7e7c360

…functionality wip

[#21] Add UserToken helper module abstraction that uses LocalStorage …

e720450

…for tokens

[#21] Add test code for making request and storing token on client si…

cc04cf4

…de - will remove

[#21] Move base URL from auth adapter to base adapter as common for e…

7df8a9c

…ntirely of application

[#21] Fix padding and add value prop to Input element. Make button ty…

9a62f4f

…pe optional

[#21] Allow form to send user/password to API for token. Use Form onS…

b5647ac

…ubmit event instead button click

[#21] Add form error handling WIP

9ff4294

liamstevens111 added this to the 0.2.0 milestone Feb 24, 2023

liamstevens111 removed the 0.1.0 label Feb 24, 2023

hanam1ni reviewed Feb 27, 2023

View reviewed changes

liamstevens111 added 2 commits March 1, 2023 11:33

[#21] Change baseAdapter request function argument name from param to…

9d0540f

… requestOption

[#21] Add generic server error to translations

61d68f0

github-actions bot temporarily deployed to pull request March 1, 2023 04:43 Inactive

[#21] Attempt to fix Netflix deploy on links not working

9538bf5

github-actions bot temporarily deployed to pull request March 1, 2023 04:58 Inactive

github-actions bot deployed to commit March 1, 2023 05:09 View deployment

[#21] Attempt to fix Netflix deploy on links not working

34943f6

github-actions bot temporarily deployed to pull request March 1, 2023 05:22 Inactive

github-actions bot temporarily deployed to pull request March 3, 2023 11:09 Inactive

[#21] Add artifact upload to test workflow for cypress failures

fb04b03

liamstevens111 force-pushed the feature/21-backend-login-email-password branch from 2e47cf0 to fb04b03 Compare March 3, 2023 11:30

github-actions bot temporarily deployed to pull request March 3, 2023 11:32 Inactive

[#21] Add artifact upload for failed cypress tests

bee4a87

github-actions bot temporarily deployed to pull request March 7, 2023 03:45 Inactive

rosle approved these changes Mar 7, 2023

View reviewed changes

[#21] Remove redundant class and javascript curcly braces for props

9929fd1

github-actions bot temporarily deployed to pull request March 8, 2023 03:51 Inactive

liamstevens111 force-pushed the feature/21-backend-login-email-password branch from 398c3d8 to 5059f71 Compare March 8, 2023 04:17

github-actions bot temporarily deployed to pull request March 8, 2023 04:19 Inactive

[#21] Fix artifact upload in workflow and add env variables to ensure…

71150ac

… cypress tests have API data

liamstevens111 force-pushed the feature/21-backend-login-email-password branch from 5059f71 to 71150ac Compare March 8, 2023 04:21

github-actions bot temporarily deployed to pull request March 8, 2023 04:22 Inactive

liamstevens111 changed the title ~~[#21] [Backend] As a user, I can login with an email and password, [#8] [UI] As a user, I can login with an email and password~~ [#21] [#8] As a user, I can login with an email and password Mar 9, 2023

liamstevens111 requested a review from hanam1ni March 10, 2023 01:07

hanam1ni approved these changes Mar 10, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#21] [#8] As a user, I can login with an email and password #35

[#21] [#8] As a user, I can login with an email and password #35

liamstevens111 commented Feb 16, 2023 •

edited

Loading

netlify bot commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023 •

edited

Loading

hanam1ni left a comment

hanam1ni Feb 27, 2023

liamstevens111 Mar 1, 2023 •

edited

Loading

hanam1ni Feb 27, 2023

liamstevens111 Mar 1, 2023 •

edited

Loading

liamstevens111 commented Mar 1, 2023 •

edited

Loading

rosle Mar 7, 2023

liamstevens111 Mar 8, 2023

rosle Mar 7, 2023

liamstevens111 Mar 8, 2023

rosle Mar 7, 2023

liamstevens111 Mar 8, 2023

liamstevens111 commented Mar 8, 2023 •

edited

Loading

	postRequest(endpoint: string, params: RequestParamsType) {
	postRequest(endpoint: string, requestOption: RequestParamsType) {

[#21] [#8] As a user, I can login with an email and password #35

Are you sure you want to change the base?

[#21] [#8] As a user, I can login with an email and password #35

Conversation

liamstevens111 commented Feb 16, 2023 • edited Loading

What happened 👀

Insight 📝

Proof Of Work 📹

netlify bot commented Feb 16, 2023 • edited Loading

✅ Deploy Preview for moonlit-buttercream-05cb2f ready!

github-actions bot commented Feb 16, 2023 • edited Loading

hanam1ni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liamstevens111 Mar 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liamstevens111 Mar 1, 2023 • edited Loading

Choose a reason for hiding this comment

liamstevens111 commented Mar 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liamstevens111 commented Mar 8, 2023 • edited Loading

liamstevens111 commented Feb 16, 2023 •

edited

Loading

netlify bot commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023 •

edited

Loading

liamstevens111 Mar 1, 2023 •

edited

Loading

liamstevens111 Mar 1, 2023 •

edited

Loading

liamstevens111 commented Mar 1, 2023 •

edited

Loading

liamstevens111 commented Mar 8, 2023 •

edited

Loading