Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix the ci broken links #314

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Attempt to fix the ci broken links #314

merged 2 commits into from
Nov 13, 2024

Conversation

AndyLHCb
Copy link
Contributor

Attempting to fix the 'broken links' which upset the build action

@AndyLHCb AndyLHCb changed the title WIP: attempt to fix the ci broken links Attempt to fix the ci broken links Nov 13, 2024
@AndyLHCb
Copy link
Contributor Author

Hi @AidanWiederhold I've updated one of the broken links in the anaprod lesson. Can you check that it now makes sense with the change with the replacement link I've chosen?

@AidanWiederhold
Copy link
Contributor

Hi @AndyLHCb this looks fine to me, though I may think about changing it up when I update to be Run 3 anyway. It maybe doesn't make sense to have this example link that will break whenever the example gets too old so I may just get rid of it and replace it with a screenshot of an example.

@AndyLHCb
Copy link
Contributor Author

Okay, then I'll merge this now to have the fix to the build system, and leave details of the lesson to you when you're ready. See also https://mattermost.web.cern.ch/lhcb/pl/txergdsg7bdk3jir4b17j5dm7h

@AidanWiederhold

@AndyLHCb AndyLHCb merged commit 7f77455 into master Nov 13, 2024
2 checks passed
@AndyLHCb AndyLHCb deleted the andylhcb-fixCI-2 branch November 13, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants