Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize query with DataUpdateCoordinator #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Zen3515
Copy link

@Zen3515 Zen3515 commented Nov 2, 2022

The main goal of this PR is to allows a single query to update multiple sensors at the same time rather than having to send 20 query requests for 20 sensors.

This PR will fix #13 and #7

To summarize here are the list of changes

  • Migrate to DataUpdateCoordinator coordinator
  • Convert to Asynchronous
  • Optimize query, allowing one query to update multiple sensor entities
  • Configurable polling rate via update_interval
  • Remove unused dependency library

@Themis3000
Copy link

Hey, thanks for your work on this! I'm curious as to if the work on this branch is complete and ready-to-go or not. I'm looking to lower my update interval by quite a bit. If it is ready to go, I'm definitely going to switch over to running your fork.

@Zen3515
Copy link
Author

Zen3515 commented Feb 12, 2023

Hey, thanks for your work on this! I'm curious as to if the work on this branch is complete and ready-to-go or not. I'm looking to lower my update interval by quite a bit. If it is ready to go, I'm definitely going to switch over to running your fork.

I believe so, I've been using my fork without any problem ever since.

@Themis3000
Copy link

Hey, thanks for your work on this! I'm curious as to if the work on this branch is complete and ready-to-go or not. I'm looking to lower my update interval by quite a bit. If it is ready to go, I'm definitely going to switch over to running your fork.

I believe so, I've been using my fork without any problem ever since.

Thank you, I just switched over to your fork and it's all working perfect! Hopefully one day it gets merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan interval
2 participants