[WIP] EVE Custom EFI App to change UEFI setings #4318
Draft
+905
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shahriyar Jalayeri <[email protected]>
shjala
requested review from
OhmSpectator,
rene,
rouming,
milan-zededa and
eriknordmark
as code owners
github-actions
bot
requested review from
christoph-zededa,
jsfakian,
rucoder and
uncleDecart
shjala
force-pushed
the
eve_efi
branch
2 times, most recently
from
ccb3f78
to
0155b1b
Compare
Signed-off-by: Shahriyar Jalayeri <[email protected]>
|
@shjala I do not really understand how SMBIOS custom string may affect EFI variable. Could you point me to a spec? |
shjala
commented
Oct 8, 2024
| } | ||
|
|
||
| CHAR8 * | ||
| GetSmbiosString( |
There was a problem hiding this comment.
@rucoder (1/2) here I get the OEM string aka type=11,value=BlahBlah, aka BlahBlah in the smbios string table.
shjala
commented
Oct 8, 2024
| CHAR16 *ConfigValue; | ||
| *TryBootOptios = FALSE; | ||
|
|
||
| Status = GetSmbiosConfigString(EVE_TRY_ALL_BOOT, &ConfigValue); |
There was a problem hiding this comment.
@rucoder (2/2) here I convert the smbios OEM string to the a predefined config value and then apply it based on what it is.
It won't, I read the SMBIOS custom string in my EFI application, if it is one of the pre-defined config values I parse it and then apply it. |
|
Reminder to add this too lf-edge/eve-api#71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to not have pre-cooked OVMF_VARS files for different UEFI settings, but to have EFI application to run and manipulate the settings to our liking before booting the guest VMs.
The EVE part is janky and hacky, I will fix that in time, right now I'm more interested to know if this is viable option or not, so @rene @eriknordmark @OhmSpectator @rucoder comments are welcomed.
This is how it works :
Efi app is simple and uses gnu-efi.