Patch Envelopes: Flatten ZInfoPatchEnvelopeUsage and remove opaque status #33
Conversation
proto/info/patch_envelope.proto
Outdated
| uint64 patchApiCallCount = 3; | ||
| // count the number of times app instance actually downloaded | ||
| // whole patch envelope or part of it | ||
| uint64 timesDownload = 4; |
There was a problem hiding this comment.
Apart from breaking changes, yetus suggests to change this to snake case. I didn't know that we are using snake case in proto messages
There was a problem hiding this comment.
Yes, we are using snake case in new protobuf (unless it is new values in an existing enum when we follow the existing convention for that enum).
The protoc produces the same output i.e., lowerCamelCase even as you change the proto file to use lower_snake_case.
proto/info/patch_envelope.proto
Outdated
| uint64 patchApiCallCount = 3; | ||
| // count the number of times app instance actually downloaded | ||
| // whole patch envelope or part of it | ||
| uint64 timesDownload = 4; |
There was a problem hiding this comment.
Both of them have the semantics of "counter", but the naming convention does not tell that at all - "times" vs. "count". Can we make the names indicate that both are counters?
There was a problem hiding this comment.
Changed to snake_case with count in name
uncleDecart
force-pushed
the
flatten-pe-usage
branch
from
eacb548
to
cfb064e
Compare
…tatus There is no need for additional structure since there is 1 to 1 releation. This commit also removes opaque status since it is duplication of AppInstMetaData Signed-off-by: Pavel Abramov <[email protected]>
…atchEnvelopeUsage Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
force-pushed
the
flatten-pe-usage
branch
from
cfb064e
to
4b8d611
Compare
Before submitting PR with Patch Envelopes status I'm opening one for EVE API to flatten
ZInfoPatchEnvelopeUsageand remove Opaque Status since it's duplication of AppInstMetadataSince this slightly changes API @gkodali-zededa @udit-zededa please review and comment :)