Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - database_download.py should check if the files have already been downloaded successfully #45

Open
flashton2003 opened this issue Apr 28, 2023 · 2 comments

Comments

@flashton2003
Copy link

Hi Nicholas,

Thanks for struo2 and hosting the databases, it's a great resource.

I'm using database_download.py to get the databases, but then the connection got interrupted part way through the download and I need to re-start.

From what I can tell from a quick read of the script, database_download.py doesn't do any check for if the file already exists/matches the MD5 before downloading it.

This would be quite a good feature to have.

If you don't have the bandwidth, I could try and find time to code it up and issue a pull request.

What are your thoughts?

Thanks,

Phil

@nick-youngblut
Copy link
Contributor

Good point @flashton2003
I don't have the bandwidth right now, but maybe sometime soon.
PRs are always welcome!

@flashton2003
Copy link
Author

Thanks Nick, hopefully I'll find the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants