Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v3 context name #690

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix v3 context name #690

wants to merge 2 commits into from

Conversation

benoit-bernard
Copy link

In V3, to connect to some devices, we need to initialize the scope contextName from the discovery

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

lextm
lextm requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@lextm lextm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default values should be OctetString.Empty instead of null. And then you can annotate the parameters as non-nullable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lextm lextm lextm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit-bernard @CLAassistant @lextm