Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export to custom paths #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kick-the-bucket
Copy link

@kick-the-bucket kick-the-bucket commented Jan 3, 2018

Strangely the trailing slash is only appended to $rootDir if one provides an export-path option.
This results in double-slashes in $outputPath, which in turn results in is_dir($outputPath) returning false, even if the directory actually exists and mkdir failing, because of undetected existing directory.

@gilles-g
Copy link
Member

Hi,
What is your environment for test? Windows, linux?

@kick-the-bucket
Copy link
Author

kick-the-bucket commented Feb 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants