Ignore token not having the getCredentials() method during decode #1244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getCredentials()
method was removed fromTokenInterface
in Symfony 6. Beside, some tokens, such asTestBrowserToken
, return null instead of the expected string type. See issue #1040.Decoding a jwt token is only meaningful when the token is a
JWTPostAuthenticationToken
. Any other token can be ignored.To fix the deprecation, the user's code must do something like this:
Now, the questions:
JWTPostAuthenticationToken
with the aim of restricting the type topublic function decode(JWTPostAuthenticationToken $token): array|bool
later on?JWTPostAuthenticationToken
without deprecation to make the use of the decode method easier?This PR is currently aiming at the first solution but solution 2 simply requires to remove the
trigger_deprecation
call.