[feat] Loosen find_references #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottming
approved these changes
Oct 8, 2024
Prior, find references would take the arity into account. This was because in elixir, a functin is defined by its name and its arity. However in practice, you more than not want to see a all the calls of a function with a given name rather than a specific head. This is especially true for functions with default arguments. As a result, this change looks for functions with a given name and any arity.
scohen
force-pushed
the
find-references-any-arity
branch
from
dbe9243
to
ef87ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior, find references would take the arity into account. This was because in elixir, a function is defined by its name and its arity. However in practice, you more than not want to see a all the calls of a function with a given name rather than a specific head. This is especially true for functions with default arguments.
As a result, this change looks for functions with a given name and any arity.