Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Important PR~not to merge without deployment plan] Upgrade to Ruby 3.3.5 #475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajdubovoy
Copy link
Contributor

@ajdubovoy ajdubovoy commented Sep 20, 2024

OK, I can't believe this is finally finished. I went through every web-dev or assess repo and upgrading the Ruby version and standardized the Rails and Puma versions.

cc @Eschults @mathildetestard

Here was basically my process:

  1. Go through every single repo (most of which are solutions/examples) and upgrade the relevant versions.
  2. Set up the DB and run server.
  3. Click around and make sure it seems like all the core features are working.

I didn't find that many huge bugs, but without automated testing on most of these, it's a bit hard for me to say there aren't any with 100% certainty.

Then I went to fullstack-solutions and did a version update there and ran rake_all to check for any broken rake tests in any challenges.

Finally, I went to fullstack-challenges and added a .ruby-version file (there wasn't already one there).

The only thing I wonder if it could slip through the cracks right now is maybe if there's a challenge where there's no rake but something weird and technical broke....it's entirely possible but a bit hard for me to predict in advance.

Sooooo many repos affected.

Related PRs:

@ajdubovoy ajdubovoy changed the title Upgrade to Ruby 3.3.5 [Important PR~not to merge without deployment plan] Upgrade to Ruby 3.3.5 Sep 20, 2024
@ajdubovoy ajdubovoy marked this pull request as ready for review September 20, 2024 16:09
@ajdubovoy
Copy link
Contributor Author

I'm also not really sure what the best deployment approach is here. It's sooooo many repos that I'd really like to avoid having to do some kind of a beta branch in an ideal world

@mathildetestard
Copy link

Huge work, thanks @ajdubovoy 👏

Hi @Eschults & @pmochkovitch 👋
What are you reco regarding deploying this change?

  • Edward you mentioned in this issue there's still a batch going on, would you recommend to wait for Sept 28?
  • do you think we can proceed without using a beta branch to save Alex some time or this is a necessary step of the process?

Thanks 🙏

@Eschults
Copy link
Member

No need for a beta branch indeed, I recommend:

  1. merging the AI evolution on Sept 28th
  2. switching batches from the AI program to the master program
  3. pulling a no-update branch from master for running batches (we don't want students to change versions in the middle of their batches)
  4. switching running batches to no-update
  5. merging this in master for upcoming batches 👌

You will need help from Engineering for steps 2 and 4, feel free to ping me 👍

@ajdubovoy
Copy link
Contributor Author

OK! Wow, making a no-update branch for this will end up being a lot of fishing, because we'll also have to move links to all the related repos to no-update. Unless we're OK with most of the Rails solution repos being on the new Ruby version even for batches where students' computers aren't on that version yet

@Eschults
Copy link
Member

Eschults commented Sep 24, 2024

Hmm let's limit the no-update branches to repos students are expected to clone / run rails s with. Teachers should be able to switch versions and I don't foresee any impacts on the corresponding demos / livecodes 🤔

Most solutions are there for students to check the code, not clone / run it as it is, even if it's a plus if they can 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants