Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Important PR~not to merge without deployment plan] Upgrade to Node 20 #474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajdubovoy
Copy link
Contributor

@ajdubovoy ajdubovoy commented Sep 11, 2024

resolve #441

I did a pretty exhaustive look through our repos, and as far as I can tell, I actually don't think upgrading node will change so much stuff!

I changed the version here in setup. Then, in fullstack-challenges, I added an .nvmrc file for those with it set up to change their version with nvm automatically. And I did the same in fullstack-solutions and then went into every single challenge in the JS units and ran rake to make sure they still raked green, ran serve to check the result myself, and ran eslint --fix * to improve the style.

But, given that the students really never use node during the challenges, I actually don't think this should affect much. And, we don't use node in Rails anymore, so I don't think it should affect any of the rails lectures or any of our Rails-related repos, agreed?

I feel like there should be more to do or something...but I think this is actually everything?

related:

@ajdubovoy ajdubovoy changed the title [WIP] Upgrade to Node 20 Upgrade to Node 20 Sep 11, 2024
@ajdubovoy ajdubovoy marked this pull request as ready for review September 11, 2024 15:30
@ajdubovoy ajdubovoy changed the title Upgrade to Node 20 [Important PR~not to merge without deployment plan] Upgrade to Node 20 Sep 11, 2024
@Eschults
Copy link
Member

Eschults commented Sep 11, 2024

👋 @ajdubovoy, indeed it should be pretty safe to upgrade w/o disrupting challenges / solutions. That said, have you checked

@ajdubovoy
Copy link
Contributor Author

Taking a look now:

@ajdubovoy
Copy link
Contributor Author

ajdubovoy commented Sep 12, 2024

opened prs for this

@ajdubovoy
Copy link
Contributor Author

All of those seemed super tiny to me and unlikely to cause issues!

@ajdubovoy
Copy link
Contributor Author

FYI also, unrelated but similar. I've started going through repos one by one and opening prs to move to the latest version of Ruby. I'll make a big pr in setup and link to alllllll the prs in the other repos once I'm done, so don't worry about checking those prs individually at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default nodeJS 18.18.0
2 participants