Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #find_or_create_professor #10

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Fix #find_or_create_professor #10

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b747e0
Fix Response::Error messages
grmnlrt Jul 18, 2023
3302ea4
Merge branch 'master' of github.com:lewagon/edusign
grmnlrt Jul 18, 2023
1977a54
Merge branch 'master' of github.com:lewagon/edusign
grmnlrt Jul 18, 2023
82b1786
Merge branch 'master' of github.com:lewagon/edusign
grmnlrt Aug 8, 2023
9ba62d2
Rescue new error in #find_or_create_professor
grmnlrt Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/edusign/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def find_or_create_professor(first_name:, last_name:, email:)

response.result
rescue Response::Error => e
raise e unless [Response::Error::PROFESSOR_NOT_FOUND_ERROR_MESSAGE, Response::Error::PROFESSOR_DELETED_ERROR_MESSAGE].include?(e.message)
raise e unless [Response::Error::PROFESSOR_NOT_FOUND_ERROR_MESSAGE, Response::Error::PROFESSOR_DELETED_ERROR_MESSAGE].include?(e.message) || e.message.include?(Response::Error::CANNOT_GET_PROFESSOR_BY_EMAIL_ERROR_MESSAGE)

response = create_professor(first_name: first_name, last_name: last_name, email: email)
response.result
Expand Down Expand Up @@ -286,6 +286,7 @@ class Response
class Error < StandardError
PROFESSOR_NOT_FOUND_ERROR_MESSAGE = "professor not found".freeze
PROFESSOR_DELETED_ERROR_MESSAGE = "professor was deleted".freeze
CANNOT_GET_PROFESSOR_BY_EMAIL_ERROR_MESSAGE = "Error - cannot get professor by email".freeze
end

attr_reader :body
Expand Down