Fix silencing of errors during ProForma mass calculations #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157
This issue also masked an error in one of the unit tests, where an attribute was misspelled. Previously, I was silently ignoring errors because not all tags have a mass value. Instead, now each tag is asked if it is expected to have a mass value, and if so, it is accessed and added to the accumulator.
Since modifications load lazily, and then read the mass value out of a
dict, theKeyErrorcould either be the result of a lookup failure for a modification resolver, or a lookup failure for the resolved properties of the modification, which would silence both mass lookup issues and modification resolution issues. Both of these are now resolved.