Skip to content

Commit

Permalink
Fix(NOISSUE): Fix docker compose file example in README.md
Browse files Browse the repository at this point in the history
In README.md is an example docker-compose.yaml file that can be improved
in two points

- The "version" top level element is obsolete, see
  https://docs.docker.com/reference/compose-file/version-and-name/
- The "command" element contains a superflous "pebble" that prevents the
  following parameters from being parsed. (In the included
  docker-compose.yaml, the "command" element is already correct, see
  https://github.com/letsencrypt/pebble/blob/e08dd94e723a0e8d005d7c6149a8666e4bf5d877/docker-compose.yml#L5
  for comparison.)
  • Loading branch information
FalkoFlessner committed Oct 16, 2024
1 parent e08dd94 commit 54f2840
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,10 @@ Pebble releases are published as Docker images to the
With a docker-compose file:

```yaml
version: '3'

services:
pebble:
image: ghcr.io/letsencrypt/pebble:latest
command: pebble -config /test/my-pebble-config.json
command: -config /test/my-pebble-config.json
ports:
- 14000:14000 # ACME port
- 15000:15000 # Management port
Expand Down

0 comments on commit 54f2840

Please sign in to comment.