Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed slidable action displaying out of the parent widget #384

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

altotunchitoo
Copy link

@altotunchitoo altotunchitoo commented Sep 30, 2022

I've clipped the SlidableAction widget child to prevent displaying it out of the parent widget boundary.
This is also the solution for the issue #337. You can see what is the problem of not clipping the widget, from the following screen record gifs.

Before :
The Slidable widget is displaying out of the parent widget. So the problem occurs when the slidable is opened and it pops the navigator.

before

After :
Fixed 💯

after

@eliasmelgaco
Copy link

thank you, @altotunchitoo !

@alexrabin
Copy link

Please merge!

@dannmf
Copy link

dannmf commented May 22, 2024

The problem persists, I believe it has not been merged.

@altotunchitoo
Copy link
Author

I've fixed the issue and it has not been merged. Meanwhile, you can use the pub from my repo.

flutter_slidable:
    git:
    url: https://github.com/altotunchitoo/flutter_slidable
    ref: master

@AlexanderSambale
Copy link

Great solution @altotunchitoo!
We can also use your idea and wrap the whole Slidable component with ClipRRect if we do not want to use another dependency.

ClipRRect(child: Slidable(...))

@Mindohyeon
Copy link

Great solution @altotunchitoo! We can also use your idea and wrap the whole Slidable component with ClipRRect if we do not want to use another dependency.

ClipRRect(child: Slidable(...))

I solved my problem through this way
I hope this pr gets merged soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants