Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use io.ReadFull to ensure that generated jwk match the expected keysize #1064

Merged
merged 1 commit into from
Jan 25, 2024

Use io.ReadFull to ensure that generated jwk match the expected keysize

3a96973
Select commit
Loading
Failed to load commit list.
Merged

Use io.ReadFull to ensure that generated jwk match the expected keysize #1064

Use io.ReadFull to ensure that generated jwk match the expected keysize
3a96973
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 25, 2024 in 1s

72.40% (+0.39%) compared to 0a15b4d

View this Pull Request on Codecov

72.40% (+0.39%) compared to 0a15b4d

Details

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (0a15b4d) 72.00% compared to head (3a96973) 72.40%.
Report is 34 commits behind head on develop/v2.

Files Patch % Lines
internal/keyconv/keyconv.go 42.42% 16 Missing and 3 partials ⚠️
jwt/openid/birthdate.go 76.47% 4 Missing ⚠️
jwe/jwe.go 91.66% 2 Missing and 1 partial ⚠️
jwe/internal/aescbc/aescbc.go 85.71% 1 Missing and 1 partial ⚠️
jwe/options_gen.go 92.30% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           develop/v2    #1064      +/-   ##
==============================================
+ Coverage       72.00%   72.40%   +0.39%     
==============================================
  Files              93       93              
  Lines           13795    13896     +101     
==============================================
+ Hits             9933    10061     +128     
+ Misses           3044     3020      -24     
+ Partials          818      815       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.