Rename jwe.WithMaxBufferSize to jwe.WithMaxAESCBCBufferSize (#1095)

lestrrat-go · Mar 9, 2024 · 13ca3a5 · 13ca3a5
1 parent 7f11f98
commit 13ca3a5
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 15 deletions.
diff --git a/jwe/jwe.go b/jwe/jwe.go
@@ -40,7 +40,7 @@ func Settings(options ...GlobalOption) {
 			maxPBES2Count = option.Value().(int)
 		case identMaxDecompressBufferSize{}:
 			maxDecompressBufferSize = option.Value().(int64)
-		case identMaxBufferSize{}:
+		case identMaxAESCBCBufferSize{}:
 			aescbc.SetMaxBufferSize(option.Value().(int64))
 		}
 	}

diff --git a/jwe/jwe_test.go b/jwe/jwe_test.go
@@ -961,10 +961,10 @@ func TestGHSA_7f9x_gw85_8grf(t *testing.T) {
 	}
 }
 
-func TestMaxBufferSize(t *testing.T) {
+func TestMaxAESCBCBufferSize(t *testing.T) {
 	// NOTE: This has GLOBAL EFFECT
-	jwe.Settings(jwe.WithMaxBufferSize(1))
-	defer jwe.Settings(jwe.WithMaxBufferSize(0))
+	jwe.Settings(jwe.WithMaxAESCBCBufferSize(1))
+	defer jwe.Settings(jwe.WithMaxAESCBCBufferSize(0))
 
 	key, err := jwxtest.GenerateRsaJwk()
 	require.NoError(t, err, `jwxtest.GenerateRsaJwk should succeed`)

diff --git a/jwe/options.yaml b/jwe/options.yaml
@@ -159,12 +159,12 @@ options:
       This option can be used for `jwe.Settings()`, which changes the behavior
       globally, or for `jwe.Decrypt()`, which changes the behavior for that
       specific call.
-  - ident: MaxBufferSize
+  - ident: MaxAESCBCBufferSize
     interface: GlobalOption
     argument_type: int64
     comment: |
-      WithMaxBufferSize specifies the maximum buffer size for internal
-      calculations, such as when AES-CBC is performed. The default value is 256MB.
+      WithMaxAESCBCBufferSize specifies the maximum buffer size for internal
+      AES-CBC calculations. The default value is 256MB.
       If set to an invalid value, the default value is used.
 
       This option has a global effect.

diff --git a/jwe/options_gen.go b/jwe/options_gen.go
diff --git a/jwe/options_gen_test.go b/jwe/options_gen_test.go