Track last error atomically #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shutton
force-pushed
the
track-last-error-atomically
branch
3 times, most recently
from
f002d49
to
8ccd2ac
Compare
|
cool! thanks for the PR |
leshow
reviewed
Jul 11, 2024
shutton
force-pushed
the
track-last-error-atomically
branch
from
8ccd2ac
to
1654e25
Compare
Eliminate the need for UdpSocket to be passed mutably into send_mmsg().
shutton
force-pushed
the
track-last-error-atomically
branch
from
1654e25
to
fcb6301
Compare
|
thanks again for the contribution |
|
My pleasure! Thanks for taking the patch so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate the need for UdpSocket to be passed mutably into send_mmsg().
While this reduces the granularity at which error messages can be logged to one second, that value wasn't configurable, and was at a very large value (60 seconds). As such, it's simple to use an atomic integer to track the last report, which eliminates the need to pass the socket in mutably to
UdpSocket::send_mmsg.This addressed a small issue in one of my projects with respect to how sockets are shared between threads.