Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify send/send_mmsg API #11

Closed
wants to merge 1 commit into from

Conversation

shutton
Copy link

@shutton shutton commented Aug 2, 2024

Eliminate need to supply elided generic type to send/send_mmsg calls with non-default batch size.

Eliminate need to supply elided generic type to send/send_mmsg calls with
non-default batch size.
@leshow
Copy link
Owner

leshow commented Aug 4, 2024

This is kind of a subjective thing, but in general I try to avoid in-argument impl Trait in public APIs. The original syntax has the advantage of allowing you to turbofish and specify the argument type, which can be useful sometimes, and it is a breaking API change to switch it.

@leshow
Copy link
Owner

leshow commented Aug 4, 2024

I suppose we already changed the API with the batch size. Anyway, I'm just going to leave it. I do appreciate the contributions though :)

@leshow leshow closed this Aug 4, 2024
@shutton
Copy link
Author

shutton commented Aug 5, 2024

Understood. I didn't like that, in order to tweak the useful generic (const), you had to go through the less-likely-to-be-specified generic (i.e., the turbofish always looks like ::<_, BATCH_SIZE>). But I can live with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants