Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 fixes for RealSpaceInterface #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timothydmorton
Copy link

The RealSpaceInterface doesn't work out of the box with python3. This fixes a number of things, including integer division and some type issues related to JSON encoding. Also makes the database pickle read/writes in binary, which also fixes some type issues.

The RealSpaceInterface doesn't work out of the box with python3.  This fixes
a number of things, including integer division and some type issues
related to JSON encoding.  Also makes the database pickle read/writes in binary,
which also fixes some type issues.
@timothydmorton
Copy link
Author

This would clearly supersede #250 which was done on an older version.

@lesgourg
Copy link
Owner

Dear @timothydmorton , I am very sorry for not following up on this, the RealSpaceInterface went out of our mind for a few years. Your PR is incredibly useful. I checked that it still works with the current CLASS version. We will incorporate these fixes in the next CLASS release (sometimes soon) with some acknowledgements for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants