Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed leak #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed leak #253

wants to merge 1 commit into from

Conversation

jose-d
Copy link

@jose-d jose-d commented Jan 11, 2019

There is memory leak reproducible in case when Class object instance is ended with some Exception.

Example:

input_dict['non_existing_param'] = 1000  # non existing param will cause exception
class_run.set(input_dict)
class_run.compute()

In this example, Class will complain with an exception bcs. of non-existing parameter, but still few bytes will stay in memory.

Depending on amount of exceptions, hundreds of GBs leak in few days.

With provided patch we observed much better behavior.

Here is graph of memory usage on compute node running code with standard Class: https://www.fzu.cz/~jose/temp/leak_grafana.png (3 days to OOM)

@jose-d
Copy link
Author

jose-d commented May 16, 2019

@lesgourg: hi, what we can do to get this merged? Or UR working on own fix?

@lesgourg
Copy link
Owner

Sorry, I promise I'll do it asap! Next week I will be working on the code and I'll commit your fix.

@jose-d
Copy link
Author

jose-d commented May 16, 2019

np, thx for info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants