This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
2.0.0 #3
Merged
2.0.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git ignores the compiled lib folder. Npm ignores the source code.
Since the language setting of the FritzBox determines the csv output, we cannot simply assume that the output is in English. Thanks @fur6y for catching this! - #4 The second line of the CSV file contains the column titles. DE: Typ ; Datum ; Name ; Rufnummer ; Nebenstelle ; Eigene Rufnummer ; Dauer EN: Type ; Date ; Name ; Telephone number ; Extension ; Telephone Number ; Duration We could count the columns and name them ourselves, or replace the second line of the CSV file and replace it with the English format. I've implemented the latter for now, this is however not the cleanest way of achieving multi-language support.
'Buffer()' was deprecated since NodeJS v6. We have to use 'Buffer.alloc()' or 'Buffer.from()'. This breaks compatibility with NodeJS < 4.5.0, however our minimum requirement is already v7. https://medium.com/@jasnell/node-js-buffer-api-changes-3c21f1048f97
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1 for the roadmap and current progress.