fix: apply padding before rendering of core text #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leostera took a shot at this one. Let me know what I need to fix :) |
|
Ooh excellent! ✨ It would be awesome if you can use these styles in one of the examples (or make a new example) so its easy to visualize that the changes work by looking at the demo gif. Let me know if I can help 🙏🏼 |
|
Hi @wonbyte and sorry for the delays! I think we will want to look into demoing this in combination with @jmcavanillas's work on escape-code aware string wrapping lib shape-the-term. I'll merge it as is for now and we can improve later on. Thanks for the contribution ✨ 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply
paddingbefore rendering core text.Addresses issue #4