Added support for AXFR query #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertoBochet
commented
Dec 24, 2021
| @@ -60,7 +60,7 @@ def _args(self, domain, query_type): | |||
| yield query_type.name | |||
|
|
|||
| # We only care about the result | |||
| yield '+short' | |||
| yield from ('+noall', '+answer') if query_type == query_type.AXFR else ('+short',) | |||
There was a problem hiding this comment.
AXFR is not a DNS entry, it is a kind of DNS query aims to extract all the DNS entries of a DNS zone, for this reason the dig output is useless without the DNS entry type. So I decided to return the full entry and not the short version.
This chose is thought in order to maintain the retro compatibility with last version. In a second moment I suggest to redefine the output schema of the library.
hardeaux
reviewed
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed