Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added language: reStructuredText #250

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

Eutropios
Copy link
Contributor

Added icon for reStructuredText, a documentation language.

Signed off: Eutropios

Added icon for reStructuredText, a documentation language.

Signed off: Eutropios September 19, 2023
@Eutropios
Copy link
Contributor Author

Eutropios commented Sep 20, 2023

I wasn't sure if this was too little or not. The language's logo is long and simple, so I just used the initials of the language. I created this via Inkscape. The software's (docutils) license is OSI-Approved Open Source, Public Domain, so we should be fine using a modified version of it.

Image: reStructuredText logo.
Source: reStructuredText Logo - Wikimedia

@xhayper
Copy link
Collaborator

xhayper commented Sep 20, 2023

the logo looks great! but can you add a background color please? thank you!

@xhayper xhayper added the enhancement New feature or request label Sep 20, 2023
@Eutropios
Copy link
Contributor Author

the logo looks great! but can you add a background color please? thank you!

Sure! What colour do you think would be a good fit for this?

@xhayper
Copy link
Collaborator

xhayper commented Sep 20, 2023

maybe dark blue? hmm...

@leonardssh
Copy link
Owner

leonardssh commented Sep 20, 2023

Dark blue: #4379ac @Eutropios

image

@Eutropios
Copy link
Contributor Author

Sounds good!

Changed reStructuredText icon's background from HSL(0, 0, 95) to
HSL(209, 44, 47).
Changed reStructuredText icon's background from HSL(0, 0, 95) to
HSL(209, 44, 47).
@Eutropios
Copy link
Contributor Author

First commit was a naming mistake which the second corrects

Copy link
Owner

@leonardssh leonardssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leonardssh leonardssh merged commit 4ac4ac1 into leonardssh:main Sep 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants