feat: support acrValues (#105)

* feat: expose AuthConfig acr values * chore: revert prettier changes * chore: apply changes from code-review * chore: revert changes to spec * chore: adds test for acrValues * chore: simplifies some stuff --------- Co-authored-by: Jose <[email protected]> Co-authored-by: Leonardo Chaia <[email protected]>
leonardochaia · Jan 3, 2024 · 4a2cc17 · 4a2cc17
1 parent 3f9eb9f
commit 4a2cc17
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 1 deletion.
diff --git a/projects/angular-simple-oidc/package.json b/projects/angular-simple-oidc/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-simple-oidc",
-  "version": "12.0.0-alpha",
+  "version": "12.0.1-alpha",
   "description": "Angular Library implementing Open Id Connect specification. Code Flow, Refresh Tokens, Session Management, Discovery Document.",
   "repository": {
     "type": "git",

diff --git a/projects/angular-simple-oidc/src/lib/config/models.ts b/projects/angular-simple-oidc/src/lib/config/models.ts
@@ -54,4 +54,9 @@ export interface AuthConfig {
      * `${window.location.protocol}//${window.location.host}${window.location.pathname}`
      */
     baseUrl?: string;
+
+    /**
+     * The authentication context class reference parameters.
+     */
+    acrValues?: string;
 }
diff --git a/projects/angular-simple-oidc/src/lib/oidc-code-flow-client.service.spec.ts b/projects/angular-simple-oidc/src/lib/oidc-code-flow-client.service.spec.ts
@@ -309,6 +309,44 @@ describe('OidcCodeFlowClientService', () => {
                 preRedirectUrl: currentLocation
             });
         }));
+
+        it('Should generate the url using provided acr values', fakeAsync(() => {
+          const doc: Partial<DiscoveryDocument> = {
+              authorization_endpoint: 'http://idp/authorize'
+          };
+
+          discoveryDocSpy.and.returnValue(of(doc));
+
+          const urlResult = {
+              codeChallenge: 'challenge',
+              codeVerifier: 'verifier',
+              nonce: 'nonce',
+              state: 'state',
+              url: 'url'
+          };
+
+          tokenUrlSpy.createAuthorizeUrl.and.returnValue(urlResult);
+
+          const redirectUri = 'redirect';
+          const idTokenHint = 'id-token-hint';
+          const prompt = 'prompt';
+          const acrValues = 'needs=wifi'
+
+          codeFlowClient.generateCodeFlowMetadata({ redirectUri, idTokenHint, prompt, acrValues })
+              .subscribe();
+          flush();
+
+          expect(tokenUrlSpy.createAuthorizeUrl)
+              .toHaveBeenCalledWith(doc.authorization_endpoint, {
+                  clientId: config.clientId,
+                  responseType: 'code',
+                  scope: config.scope,
+                  redirectUri: redirectUri,
+                  idTokenHint: idTokenHint,
+                  prompt: prompt,
+                  acrValues
+              });
+        }));
     });
 
     describe('Code Flow Callback', () => {

diff --git a/projects/angular-simple-oidc/src/lib/oidc-code-flow-client.service.ts b/projects/angular-simple-oidc/src/lib/oidc-code-flow-client.service.ts
@@ -79,6 +79,7 @@ export class OidcCodeFlowClient {
                     clientId: config.clientId,
                     scope: config.scope,
                     responseType: 'code',
+                    ...config.acrValues && { acrValues: config.acrValues },
                     ...params,
                 })),
                 take(1),