feat: set cwd for dlv based on program #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcoqzeug
force-pushed
the
set-cwd-for-dlv
branch
from
14d7ebf
to
468c74a
Compare
This potentially resolves leoluz#85. vscode-go sets dlv cwd based on the value of program. Reference: https://github.com/golang/vscode-go/blob/master/extension/src/goDebugConfiguration.ts#L545
mcoqzeug
force-pushed
the
set-cwd-for-dlv
branch
from
468c74a
to
9959cb5
Compare
leoluz
requested changes
Oct 5, 2024
mcoqzeug
force-pushed
the
set-cwd-for-dlv
branch
from
efeafcf
to
36c06fd
Compare
mcoqzeug
force-pushed
the
set-cwd-for-dlv
branch
from
36c06fd
to
b49e81a
Compare
leoluz
requested changes
Oct 17, 2024
There was a problem hiding this comment.
@mcoqzeug Thank you for removing plenary dependency.
I noticed that you are re-implementing file path logic that is already available as vim functions. The get_parent function for example can be replaced by fnamemodify (see https://stackoverflow.com/questions/16485748/how-to-get-the-parent-directory-of-a-path-string). Similar strategy can be used to extract the file extension with filename-modifier :e (see https://vimhelp.org/cmdline.txt.html#filename-modifiers)
mcoqzeug
force-pushed
the
set-cwd-for-dlv
branch
from
e609d2e
to
6c29287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially resolves #85.
dlv.executable.cwdbased on the value ofdebug_config.program. Ifprogramis a directory, setcwdtoprogram. Ifprogramis a path to a go file, setcwdto its parent directory.programto absolute path.We probably don't need
config.delve.cwdanymore.Reference: https://github.com/golang/vscode-go/blob/master/extension/src/goDebugConfiguration.ts#L545