Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add build flags function for custom configurations #92

Merged
merged 1 commit into from
Jul 19, 2024
Merged

feat: add build flags function for custom configurations #92

merged 1 commit into from
Jul 19, 2024

Conversation

nkane
Copy link
Contributor

@nkane nkane commented Jul 3, 2024 •
edited
Loading

Description

  • add get_build_flags functions that works the same as get_arguments in order to get go build flags interactively.
  • add additional exposed functions that call get_build_flags and get_arguments to allow users to be able to reuse these functions within their own customer configurations.
  • add local global configuration to store initialized configuration settings.
  • updated readme and docs files with relevant change information.

@nkane nkane force-pushed the feat/add-dap-build-flag-opt branch from 796c5d6 to 0dfd678 Compare July 3, 2024 18:52
@nkane nkane changed the title feat: add build as option for default list feat: add build flags as option for default list Jul 3, 2024
@nkane nkane force-pushed the feat/add-dap-build-flag-opt branch from 0dfd678 to be9bdfa Compare July 3, 2024 20:01
leoluz
leoluz requested changes Jul 4, 2024
View reviewed changes
Copy link
Owner

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tks for the PR.
Please update the documentation in the README.md and doc/nvim-dap-go.txt describing the new feature.

lua/dap-go.lua Outdated Show resolved Hide resolved
lua/dap-go.lua Show resolved Hide resolved
@nkane nkane marked this pull request as draft July 5, 2024 18:41
@nkane nkane force-pushed the feat/add-dap-build-flag-opt branch 2 times, most recently from d5dd792 to 09f68e7 Compare July 6, 2024 01:40
@nkane nkane force-pushed the feat/add-dap-build-flag-opt branch from 09f68e7 to 81226c2 Compare July 6, 2024 01:44
@nkane nkane marked this pull request as ready for review July 6, 2024 01:44
@nkane nkane requested a review from leoluz July 6, 2024 01:45
@nkane nkane changed the title feat: add build flags as option for default list feat: add build flags function for custom configurations Jul 6, 2024
leoluz
leoluz approved these changes Jul 19, 2024
View reviewed changes
Copy link
Owner

@leoluz leoluz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your contribution!

@leoluz leoluz merged commit 6da41ff into leoluz:main Jul 19, 2024
2 checks passed
@nkane nkane deleted the feat/add-dap-build-flag-opt branch July 19, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkane @leoluz