Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configuration to enable tests verbosity #90

Merged
merged 7 commits into from
Jul 19, 2024

Conversation

gustavooferreira
Copy link
Contributor

I really like the feature of running the closest test to the cursor.

However, I usually make use of the t.Logf method which logs stuff when running tests. Without verbosity being turned on these logs will only show when the tests fail.

This PR adds an option to the plugin to enable verbosity. It sets this option to false by default so as to not change the behaviour of the plugin.

@hmajid2301
Copy link

This is a really cool feature! would love to have this in dap-go.

Copy link
Owner

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tks for contributing!
Just one doc request but overall looking good.

README.md Show resolved Hide resolved
Copy link
Owner

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tks for your contribution!

@leoluz leoluz changed the title Add tests verbosity feat: Add configuration to enable tests verbosity Jul 19, 2024
@leoluz leoluz merged commit 5030d53 into leoluz:main Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants