Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Support N26 2024 CSV Format #662

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SheetMetalConnect
Copy link

Added support for N26's 2024 CSV export format while ensuring compatibility with existing formats. Updated the parser to handle various transaction types including Credit Transfer, Debit Transfer, Presentment, and Reward.

Changes

  • n26.ts

    • Updated the N26Row interface to include fields specific to the 2024 format.
    • Enhanced the parser to recognize and process different transaction types.
    • Modified the matcher to detect the new format based on headers.
  • n26.spec.ts

    • Added tests for the 2024 CSV format to ensure accurate parsing.
    • Uploaded a sample anonymized 2024 CSV file for testing purposes.

Sample CSV

A sample file named BusinessAccount_2024-08-01_2024-08-10.csv has been added to the repository to demonstrate the new format and facilitate testing.

@SheetMetalConnect SheetMetalConnect changed the title Pull Request: Support N26 2024 CSV Format* Update Support N26 2024 CSV Format Sep 30, 2024
@SheetMetalConnect
Copy link
Author

Closing #661

@leolabs
Copy link
Owner

leolabs commented Oct 8, 2024

Hey @SheetMetalConnect, thank you so much for your PR!

I've run the tests, but they seem to fail on older N26 files. It seems that the inflow/outflow amount is incorrectly parsed, and off by a factor of 10 or 100. Could you take a look at this and check if it can be fixed?

I'm looking forward to your reply!

@Saandji
Copy link

Saandji commented Oct 29, 2024

Hey @SheetMetalConnect really appreciate the effort on trying to fix the issue! Do you have any ETA when you think it might get fixed?

Thanks for your work!

@SheetMetalConnect SheetMetalConnect marked this pull request as draft November 16, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants