Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add missing comma in JSON file #27

Merged
merged 2 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/release-please.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,24 @@ jobs:
upload-release-artifact:
needs: release-please
runs-on: ubuntu-latest
if: ${{ needs.release-please.outputs.releases_created }}
steps:
- name: "Check out the repository"
if: ${{ needs.release-please.outputs.releases_created }}
uses: actions/checkout@v4

- name: "Setup Java and Maven"
if: ${{ needs.release-please.outputs.releases_created }}
uses: actions/setup-java@v4
with:
java-version: '21'
distribution: 'temurin'

- name: "Package JAR using Maven wrapper"
if: ${{ needs.release-please.outputs.releases_created }}
run: ./mvnw dependency:go-offline clean compile package

- name: "Upload Release Artifact"
if: ${{ needs.release-please.outputs.releases_created }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: gh release upload ${{ steps.release-please.outputs.tag_name }} ./target/shadow-${{ steps.release-please.outputs.major }}.${{ steps.release-please.outputs.minor }}.${{ steps.release-please.outputs.patch }}.jar
2 changes: 1 addition & 1 deletion release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
],
"include-v-in-tag": true,
"include-component-in-tag": false,
"pull-request-title-pattern": "chore: release ${version}"
"pull-request-title-pattern": "chore: release ${version}",
"label": "autorelease-pending",
"release-label": "autorelease-tagged",
"bump-minor-pre-major": true,
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/ch/heigvd/dai/utilities/FileManipulator.java
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public void writeBytesToFile(byte[] bytes) throws IOException, RuntimeException
if (!writeEnabled)
throw new RuntimeException(
"Unable to write to file, because write operations are not activated for this object.");

try (FileOutputStream fileOutputStream = new FileOutputStream(file);
BufferedOutputStream bufferedOutputStream = new BufferedOutputStream(fileOutputStream)) {
bufferedOutputStream.write(bytes);
Expand Down