Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversion: Tech debt: Revert to KCQL java tests #1235

Merged
merged 1 commit into from
May 29, 2024

Conversation

davidsloan
Copy link
Collaborator

@davidsloan davidsloan commented May 22, 2024

This is a very quick PR to revert the KCQL tests from the scala tests back to the java tests as originally from
https://github.com/lensesio/kafka-connect-query-language/tree/master/src/test/java/com/datamountaineer/kcql

This removes the need to have any scala code in the java-connectors directory.

Please note:

  • These aren't my work and I have done the minimum to update them to junit 5 with a few assertJ assertions sprinkled around. I'm not sure this should be reviewed as "new code" but I will aim to address comments nonetheless.
  • I have added IDE-generated equals and hashCode methods to some of the KCQL objects.
  • I haven't used Lombok for these as this would involve getting Lombok working on the KCQL module for both scala and java. This must also hook in with the Antlr generation so I have left it out of scope for what is supposed to be a relatively quick reversion.
  • I have compared the tests in the scala code and java code and ensured changes since the code was switched to scala has been ported to the scala code.

@davidsloan davidsloan force-pushed the chore/revert-to-java-kcql-tests branch from c41c245 to 6813b61 Compare May 23, 2024 09:09
@davidsloan davidsloan force-pushed the chore/revert-to-java-kcql-tests branch from 6813b61 to 6b92c6b Compare May 29, 2024 14:20
@davidsloan davidsloan merged commit 53355ef into master May 29, 2024
166 checks passed
@davidsloan davidsloan deleted the chore/revert-to-java-kcql-tests branch May 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants