Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update all outdated dependencies #468

Merged
merged 9 commits into from
Aug 15, 2023
Merged

chore: update all outdated dependencies #468

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
563e1f0
chore: update eslint-config-prettier and eslint-plugin-import
reecejohnson Aug 3, 2023
1dff7eb
chore: update typedoc verion
reecejohnson Aug 3, 2023
c82f228
chore(deps): update jest monorepo
renovate[bot] Jul 27, 2023
8c5f206
chore: revert back to eslint-plugin-import:2.26.0 due to import order…
reecejohnson Aug 3, 2023
8d107fa
chore: disable @typescript-eslint/no-unsafe-assignment
reecejohnson Aug 3, 2023
21c1d9e
chore: only disable @typescript-eslint/no-unsafe-assignment in tests …
reecejohnson Aug 3, 2023
1fb3680
chore: rollback typedoc
reecejohnson Aug 14, 2023
c6bdb22
chore(deps): update dependency ganache to v7.9.0
renovate[bot] Aug 14, 2023
5a57e35
chore(deps): update dependency node to v18.17.1
renovate[bot] Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"prettier": "^2.8.4",
"rimraf": "^4.1.2",
"turbo": "^1.8.1",
"typedoc": "^0.23.27",
"typedoc": "^0.24.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check if pnpm typedoc still works? I remember having some issues with the updated version some time ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, you're right.

big breaking changes introduced in 0.24.0 regarding the package entryPointStrategy.

reverting the version and creating separate ticket

"typescript": "^4.9.5"
},
"resolutions": {
Expand Down
2 changes: 1 addition & 1 deletion packages/api-bindings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@lens-protocol/eslint-config": "workspace:*",
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
"@types/node": "^18.15.11",
"babel-plugin-graphql-tag": "^3.3.0",
"eslint": "^8.34.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/blockchain-bindings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@lens-protocol/eslint-config": "workspace:*",
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
"eslint": "^8.34.0",
"jest": "^29.4.3",
"ts-jest": "^29.0.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@lens-protocol/eslint-config": "workspace:*",
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
"@types/node": "^18.15.11",
"eslint": "^8.34.0",
"ethers": "^5.7.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/domain/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"@lens-protocol/eslint-config": "workspace:*",
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
"@types/jest-when": "^3.5.2",
"eslint": "^8.34.0",
"jest": "^29.4.3",
Expand Down
2 changes: 2 additions & 0 deletions packages/eslint-config/index.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,15 @@ module.exports = {
'@typescript-eslint/no-var-requires': 'off',
'@typescript-eslint/no-shadow': 'off',
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/no-unsafe-assignment': 'off',
},
},

{
files: ['**/*.spec.{js,ts,tsx}'],
rules: {
'tsdoc/syntax': 'off',
'@typescript-eslint/no-unsafe-assignment': 'off',
},
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dependencies": {
"@typescript-eslint/eslint-plugin": "^5.52.0",
"@typescript-eslint/parser": "^5.52.0",
"eslint-config-prettier": "^8.6.0",
"eslint-config-prettier": "^8.10.0",
"eslint-plugin-import": "2.26.0",
"eslint-plugin-tsdoc": "^0.2.17"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/gated-content/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@lens-protocol/eslint-config": "workspace:*",
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the build passes I assume we don't have type checks issue with our use of Jest.

There is warning at the end of this Jest doc page: https://jestjs.io/docs/getting-started#type-definitions that suggests to keep types and jest versions as in sync as possible. I think they also follow semver so higher version of the types should support older version of Jest.

image

Let's keep an eye on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, thanks 👍

"@types/jest-when": "^3.5.2",
"@types/node": "^18.15.11",
"eslint": "^8.34.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@testing-library/react": "^13.4.0",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
"@types/jest-when": "^3.5.2",
"@types/react": "^18.0.28",
"eslint": "^8.34.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@testing-library/react": "^13.4.0",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
"@types/jest-when": "^3.5.2",
"@types/lodash": "^4.14.191",
"@types/react": "^18.0.28",
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/profile/adapters/__tests__/ProfileTransactionGateway.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ describe(`Given an instance of the ${ProfileTransactionGateway.name}`, () => {
expect.objectContaining({
chainType: ChainType.POLYGON,
hash: relayerResult.txHash,
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
id: expect.any(String),
request,
}),
Expand Down
10 changes: 0 additions & 10 deletions packages/react/src/transactions/adapters/__tests__/ApproveTransactionGateway.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,20 +64,15 @@ describe(`Given an instance of the ${ApproveTransactionGateway.name}`, () => {
expect(unsignedTransaction).toBeInstanceOf(UnsignedApproveTransaction);
expect(unsignedTransaction).toEqual({
chainType: request.amount.asset.chainType,
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
id: expect.any(String),
request,
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
transactionRequest: expect.objectContaining({
data: erc20(request.amount.asset.address, provider).interface.encodeFunctionData(
'approve',
[request.spender, utils.parseEther(request.amount.toSignificantDigits())],
),
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
gasLimit: expect.any(BigNumber),
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
maxFeePerGas: expect.any(BigNumber),
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
maxPriorityFeePerGas: expect.any(BigNumber),
from: wallet.address,
type: 2, // EIP-1559
Expand Down Expand Up @@ -112,20 +107,15 @@ describe(`Given an instance of the ${ApproveTransactionGateway.name}`, () => {
expect(unsignedTransaction).toBeInstanceOf(UnsignedApproveTransaction);
expect(unsignedTransaction).toEqual({
chainType: request.amount.asset.chainType,
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
id: expect.any(String),
request,
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
transactionRequest: expect.objectContaining({
data: erc20(request.amount.asset.address, provider).interface.encodeFunctionData(
'approve',
[request.spender, constants.MaxUint256],
),
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
gasLimit: expect.any(BigNumber),
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
maxFeePerGas: expect.any(BigNumber),
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
maxPriorityFeePerGas: expect.any(BigNumber),
from: wallet.address,
type: 2, // EIP-1559
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/transactions/adapters/__tests__/ProfileImageCallGateway.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ describe(`Given an instance of the ${ProfileImageCallGateway.name}`, () => {
expect(result.unwrap()).toEqual(
expect.objectContaining({
chainType: ChainType.POLYGON,
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
id: expect.any(String),
request,
}),
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/wallet/adapters/__tests__/ConcreteWallet.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ describe(`Given an instance of ${ConcreteWallet.name}`, () => {
expect(result.unwrap()).toEqual(
expect.objectContaining({
chainType,
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
hash: expect.any(String),
id: unsignedTransaction.id,
request: unsignedTransaction.request,
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk-gated/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@rollup/plugin-replace": "^5.0.2",
"@rollup/plugin-terser": "^0.4.0",
"@rollup/plugin-typescript": "^11.0.0",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
"@types/node": "^18.15.11",
"@types/pako": "^2.0.0",
"blob-polyfill": "^7.0.20220408",
Expand Down
2 changes: 1 addition & 1 deletion packages/shared-kernel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@lens-protocol/eslint-config": "workspace:*",
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
"@types/lodash": "^4.14.191",
"@types/uuid": "^9.0.0",
"eslint": "^8.34.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/storage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@lens-protocol/eslint-config": "workspace:*",
"@lens-protocol/prettier-config": "workspace:*",
"@lens-protocol/tsconfig": "workspace:*",
"@types/jest": "29.2.3",
"@types/jest": "29.5.3",
"@types/node": "^18.15.11",
"eslint": "^8.34.0",
"jest": "^29.4.3",
Expand Down
Loading